Wicket
  1. Wicket
  2. WICKET-4761

ModalWindow.closeCurrent Javascript error

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.7
    • Fix Version/s: 6.1.0, 1.5.9
    • Component/s: wicket-extensions
    • Labels:
      None
    • Environment:
      Internet Explorer 9

      Description

      Hi,

      I have a window with a page on it that can upload a file. After uploading the file I call methode ModalWindow.closeCurrent for closing the window. But it doesn't close in internet explorer 9, in the ajax-debug window I get the following error:
      ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: SyntaxError: Expected ';'

      So I debugged in ModalWindow and when I change the javascript in ModalWindow getCloseJavacriptInternal line 418: var close = function()

      {...}

      ; with that last ';' then it works fine.

      Thanks
      Ann

        Activity

        Hide
        Emond Papegaaij added a comment -

        I've added the semicolon and removed another one, which wasn't needed. I don't have IE to test this is, but the semicolon was indeed missing (it's an assignment). Normally the JS-engine should insert a semicolon, but perhaps this doesn't work due to way this js is executed. It's better to just put the semicolons where they are supposed to go and not rely on any auto semicolon insertion.

        Show
        Emond Papegaaij added a comment - I've added the semicolon and removed another one, which wasn't needed. I don't have IE to test this is, but the semicolon was indeed missing (it's an assignment). Normally the JS-engine should insert a semicolon, but perhaps this doesn't work due to way this js is executed. It's better to just put the semicolons where they are supposed to go and not rely on any auto semicolon insertion.

          People

          • Assignee:
            Emond Papegaaij
            Reporter:
            Ann Baert
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development