Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4736

JavaScriptFilteredIntoFooterHeaderResponse should reverse filter logic

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.5.8, 6.0.0
    • 6.1.0, 1.5.9
    • wicket
    • None

    Description

      JavaScriptFilteredIntoFooterHeaderResponse creates two buckets. One for CSS and one for JS. The current logic is that everything that isn't CSS must be JS and so gets put at the bottom of the page. This breaks if CssAcceptingHeaderResponseFilter mistakingly identifies something as non-CSS (eg a CSS file with another extension). Also everything else that isn't CSS gets put into the footer bucket (which should contain only JS).

      It would be better if it only puts things in the footer bucket if it can determine that it's JS and sort everything else into the header bucket.

      Attachments

        Activity

          People

            mgrigorov Martin Tzvetanov Grigorov
            cleiter Christoph Leiter
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: