Wicket
  1. Wicket
  2. WICKET-4736

JavaScriptFilteredIntoFooterHeaderResponse should reverse filter logic

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.8, 6.0.0
    • Fix Version/s: 6.1.0, 1.5.9
    • Component/s: wicket
    • Labels:
      None

      Description

      JavaScriptFilteredIntoFooterHeaderResponse creates two buckets. One for CSS and one for JS. The current logic is that everything that isn't CSS must be JS and so gets put at the bottom of the page. This breaks if CssAcceptingHeaderResponseFilter mistakingly identifies something as non-CSS (eg a CSS file with another extension). Also everything else that isn't CSS gets put into the footer bucket (which should contain only JS).

      It would be better if it only puts things in the footer bucket if it can determine that it's JS and sort everything else into the header bucket.

        Activity

        Hide
        Martin Grigorov added a comment - - edited

        Fixed.

        Methods' signatures were broken but since the class is final there is no chance that someone has overridden it.

        Show
        Martin Grigorov added a comment - - edited Fixed. Methods' signatures were broken but since the class is final there is no chance that someone has overridden it.

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Christoph Leiter
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development