[WICKET-4721] ConcatBundleResource is unnecessarily limited to accepting PackageResourceReference

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.0.0-beta3
• Fix Version/s: 6.0.0
• Assignee: Emond Papegaaij
• Reporter: Luke Niesink
• Created: 21/Aug/12 14:18
• Updated: 22/Aug/12 08:42
• Resolved: 22/Aug/12 08:42

Description

ConcatBundleResource (and ConcatResourceBundleReference) are currently limited to concatenating resources of the type PackageResource.

The only methods of the specified PackageResource's used by ConcatBundleResource are PackageResource#getCacheKey() and PackageResource#getResourceStream().

The implementation of PackageResource#getResourceStream() is (nearly) identical to PackageResource#getCacheableResourceStream().

The methods PackageResource#getCacheKey() and PackageResource#getCacheableResourceStream() are both implemented as part of the interface IStaticCacheableResource.

ConcatBundleResource (and ConcatResourceBundleReference) should, in my vision, therefor be able to concatenate all resources that implement IStaticCacheableResource.