[WICKET-4715] WebApplication doesn't recognize if an incoming request is multipart.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.7, 6.0.0-beta3
• Fix Version/s: 1.5.8, 6.0.0
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Andrea Del Bene
• Created: 16/Aug/12 15:03
• Updated: 01/Oct/12 08:59
• Resolved: 07/Sep/12 09:03

Description

Thanks to the mail at http://apache-wicket.1842946.n4.nabble.com/Read-POST-based-request-from-external-site-td4651269.html we have spotted a problem with method newWebRequest of class WebApplication.
It seems that this method doesn't test if the original request is multipart and doing so post parameters go lost.
We should create a MultipartServletWebRequestImpl when such a type of request is being served. I attach a possible patch but I'm not 100% about two things:

• which is the best way to determinate if a HttpServletRequest is multipart?
• in order to build a MultipartServletWebRequestImpl we need to provide a string identifier for the upload. How can we generate it (in my patch it's a constant value)?

Issue Links

• breaks: WICKET-4791 UploadProgressBar hides immediately after being shown.

Sub-Tasks

• Revert Wicket-4715 -Read multipart request params in WebApplication: Resolved