Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4707

Remove ResourceReference.getDependencies()

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Later
    • Affects Version/s: 6.0.0-beta3
    • Fix Version/s: None
    • Component/s: wicket
    • Labels:
      None

      Description

      There is some duplication of functionality between the ResourceReference and HeaderItem layers.

      ResourceReferences should not be responsible for managing header contribution dependencies. This is the job of HeaderItem. ResourceReference's job is to provide a reference to a IResource. In that context, getDependencies() unnecessary.

      ResourceReference is the layer below HeaderItem, but implementation problems of HeaderItem have crept into the lower layer.

      In the same vein, IJavaScriptLibrarySettings should manage HeaderItems, not ResourceReferences. It is concerned with making sure that the correct header contributions have been made for the various Javascript things to work. This can be done entirely without ResourceReferences, but not without HeaderItems. The important things is the header items.

      Working on some patches...

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jesselong Jesse Long
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: