[WICKET-4663] LazyInitProxyFactory uses wrong ClassLoader in OSGi environment

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.7
• Fix Version/s: 1.5.8, 6.0.0
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Stefan
• Created: 20/Jul/12 07:55
• Updated: 23/Jul/12 13:46
• Resolved: 23/Jul/12 08:14

Description

The method LazyInitProxyFactory#createProxy use Thread.currentThread().getContextClassLoader() to create a new proxy instance. It seems that this is not correct in an OSGi environment.

Preferred is to use the ClassLoader provided by the AbstractClassResolver class (getClassResolver is not part of IClassResolver).

Then it will be something like:

ClassLoader classLoader;
if (Application.exists())

{ AbstractClassResolver classResolver = (AbstractClassResolver) Application.get() .getApplicationSettings() .getClassResolver(); classLoader = classResolver.getClassLoader(); }

else

{ classLoader = Thread.currentThread().getContextClassLoader(); }

try
{
return Proxy.newProxyInstance(classLoader, new Class[]

{ type, Serializable.class, ILazyInitProxy.class, IWriteReplace.class }

, handler);
}