Wicket
  1. Wicket
  2. WICKET-4546

Unencoded ampersands in CSS-/Javascript-Reference

    Details

      Description

      Ampersands in CSS-/Javascript-References are not encoded properly, see the source code (html) in:

      http://www.wicket-library.com/wicket-examples/resourceaggregation

      <!-- BasicGroupingKey [group=GLOBAL, loadOrder=0, css=true] -->
      <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:footer.css%7Corg.apache.wicket.examples.resourcedecoration.HomePage:header.css&type=css" />
      <!-- BasicGroupingKey [group=APPLICATION, loadOrder=0, css=true] -->
      <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:app.css&type=css" />
      <!-- BasicGroupingKey [group=PAGE, loadOrder=0, css=true] -->
      <link rel="stylesheet" type="text/css" href="./wicket/resource/org.apache.wicket.Application/merged-resources?refs=org.apache.wicket.examples.resourcedecoration.HomePage:HomePage.css&type=css" />

        Activity

        Arne Baganz created issue -
        Hide
        Martin Grigorov added a comment -

        This is how org.apache.wicket.examples.resourcedecoration.MergedResourcesResource works.
        It puts '|' in the query parameter value and then splits on it.

        Show
        Martin Grigorov added a comment - This is how org.apache.wicket.examples.resourcedecoration.MergedResourcesResource works. It puts '|' in the query parameter value and then splits on it.
        Martin Grigorov made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Not A Problem [ 8 ]
        Hide
        Arne Baganz added a comment -

        I did not mean the pipe ( | ) symbol but the ampersand ( & ).

        See: http://www.htmlhelp.com/tools/validator/problems.html#amp

        So according to the W3C it is a problem.

        Ampersand encoding in wicket has quite a ticket history, just to name a few:

        WICKET-358 WICKET-559 WICKET-2131 WICKET-3334

        Show
        Arne Baganz added a comment - I did not mean the pipe ( | ) symbol but the ampersand ( & ). See: http://www.htmlhelp.com/tools/validator/problems.html#amp So according to the W3C it is a problem. Ampersand encoding in wicket has quite a ticket history, just to name a few: WICKET-358 WICKET-559 WICKET-2131 WICKET-3334
        Hide
        Martin Grigorov added a comment -

        Which ampersand exactly do you mean ?

        Show
        Martin Grigorov added a comment - Which ampersand exactly do you mean ?
        Hide
        Martin Grigorov added a comment -

        The ampersands in the urls are normal delimiters for the request parameters, no ?

        Show
        Martin Grigorov added a comment - The ampersands in the urls are normal delimiters for the request parameters, no ?
        Hide
        Arne Baganz added a comment -

        The ampersand before &type, i.e. &type=css or custom parameters if I add any.

        Show
        Arne Baganz added a comment - The ampersand before &type, i.e. &type=css or custom parameters if I add any.
        Hide
        Martin Grigorov added a comment -

        You are correct.

        Show
        Martin Grigorov added a comment - You are correct.
        Martin Grigorov made changes -
        Resolution Not A Problem [ 8 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Martin Grigorov added a comment -

        Improved! Thanks!
        Wicket is even more famous now!

        Show
        Martin Grigorov added a comment - Improved! Thanks! Wicket is even more famous now!
        Martin Grigorov made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]
        Fix Version/s 6.0.0-RC1 [ 12320343 ]
        Fix Version/s 1.5.7 [ 12321241 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Arne Baganz
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development