Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4535

Inconsistent use of generics in sorting APIs

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.0.0-beta1
    • Fix Version/s: 6.0.0-beta2
    • Component/s: wicket-extensions
    • Labels:
      None

      Description

      The Sort APIs use very generics inconsistently. Classes like SortableDataProvider, ISortState, SortParam etc do not all uniformly cater for sort properties other than string. There is a lot of unchecked casting, which is not really required, if generics were used across the board.

      Fixing this will probably cause API changes for 6.

        Attachments

        1. WICKET-4535-5.patch
          15 kB
          Jesse Long
        2. WICKET-4535-4.patch
          15 kB
          Jesse Long
        3. WICKET-4535-3.patch
          1 kB
          Jesse Long
        4. WICKET-4535-2.patch
          101 kB
          Jesse Long
        5. WICKET-4535-1.patch
          30 kB
          Jesse Long
        6. myproject.zip
          24 kB
          Jesse Long

          Activity
          $i18n.getText('security.level.explanation', $currentSelection) Viewable by All Users
          Cancel

            People

            • Assignee:
              mgrigorov Martin Tzvetanov Grigorov
              Reporter:
              jesselong Jesse Long

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment