Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4535

Inconsistent use of generics in sorting APIs

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 6.0.0-beta1
    • 6.0.0-beta2
    • wicket-extensions
    • None

    Description

      The Sort APIs use very generics inconsistently. Classes like SortableDataProvider, ISortState, SortParam etc do not all uniformly cater for sort properties other than string. There is a lot of unchecked casting, which is not really required, if generics were used across the board.

      Fixing this will probably cause API changes for 6.

      Attachments

        1. myproject.zip
          24 kB
          Jesse Long
        2. WICKET-4535-1.patch
          30 kB
          Jesse Long
        3. WICKET-4535-2.patch
          101 kB
          Jesse Long
        4. WICKET-4535-3.patch
          1 kB
          Jesse Long
        5. WICKET-4535-4.patch
          15 kB
          Jesse Long
        6. WICKET-4535-5.patch
          15 kB
          Jesse Long

        Activity

          People

            mgrigorov Martin Tzvetanov Grigorov
            jesselong Jesse Long
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: