[WICKET-4524] ListMultipleChoice has a performance issue with very large lists, patch included

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.20
• Fix Version/s: 1.5.7, 6.0.0-beta2
• Component/s: wicket
• Labels: performance
• Assignee: Carl-Eric Menzel
• Reporter: Martin Terra
• Created: 28/Apr/12 15:50
• Updated: 07/May/12 15:03
• Resolved: 07/May/12 15:03

Description

If ListMultipleChoice has thousands of options, the convertChoiceIdsToChoices method will become a performance bottleneck because it has a O(N^2) algorithm for determining the selected items. This patch suggests an optimization using a HashMap which will have a performance improvement in cases of large choices lists (users typically 'select all' in such situation).