Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4438 Make Wicket more OSGi friendly
  3. WICKET-4517

Wicket-core don't export "internal" packages in OSGi manifest.

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 6.0.0-beta1
    • 6.0.0-beta2
    • wicket
    • None

    Description

      The default behavior of Maven Bundle Plugin is to exclude package '.' and any packages containing 'impl' or 'internal'. For this reason 'wicket-core' is not exporting 'org.apache.wicket.markup.head.internal' and 'org.apache.wicket.markup.html.internal'.

      And 'wicket-extensions' is trying to import 'org.apache.wicket.markup.html.internal' but since it is not exported by wicket-core when you try to start it in a OSGi container it fails.

      I've solved this issue adding an <Export-Package> tag to the main pom.xml. But I wasn't able to run the tests (even without changing anything), so I don't know if there is something broken (I don't think so).

      @@ -746,6 +746,7 @@
      </goals>
      <configuration>
      <instructions>
      + <Export-Package>org.apache.wicket*</Export-Package>
      <Import-Package>org.apache.wicket*</Import-Package>
      <DynamicImport-Package>*</DynamicImport-Package>
      <_nouses>true</_nouses>

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mgrigorov Martin Tzvetanov Grigorov
            jordeu Jordi Deu-Pons
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment