[WICKET-4498] Ignore Netbeans XML configuration files in Apache License Header Test Case

• Type: Wish
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 6.0.0-beta2
• Fix Version/s: 1.5.6, 6.0.0-beta2
• Component/s: wicket
• Labels: test
• Environment: Netbeans IDE
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Timo Schmidt
• Created: 13/Apr/12 15:45
• Updated: 16/Apr/12 09:43
• Resolved: 16/Apr/12 09:43

Description

First of all, thank you for this great framework. It's a pleasure to work with wicket!

As I'm using the Netbeans IDE for development the Apache License Header Test Case fails due to missing license text block in some Netbeans configuration files. The following patch will ignore those Netbeans specific files and the tests will pass.

diff --git a/wicket-util/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java b/wicket-util/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
index fc19ca2..dc6cee3 100644
— a/wicket-util/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
@@ -211,6 +211,7 @@ public abstract class ApacheLicenseHeaderTestCase extends Assert
// addHeaders = true;
xmlIgnore.add(".settings");
xmlIgnore.add("EclipseCodeFormat.xml");
+ xmlIgnore.add("nb-configuration.xml");

/*

• License header in test files lower the visibility of the test.

It would be nice to add the above ignore line.