Wicket
  1. Wicket
  2. WICKET-4480

newResourceResponse() always process IResourceStream

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.5, 6.0.0-beta1
    • Fix Version/s: 1.5.6, 6.0.0-beta2
    • Component/s: wicket
    • Labels:

      Description

      The conditional statement 'if (resourceResponse.dataNeedsToBeWritten(attributes))' in PackageResource$newResourceResponse always turns true.

      dataNeedsToBeWritten() method internally uses its own lastModified field, which is null (by default) and always returns true at that point resulting in getting a stream and processing it every time.

      I think this ruins resource caching.

      NOTE: The API document of dataNeedsToBeWritten() exclaims setLastModified() be called first.

        Activity

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Terasaka Kinya
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development