[WICKET-4480] newResourceResponse() always process IResourceStream

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.5, 6.0.0-beta1
• Fix Version/s: 1.5.6, 6.0.0-beta2
• Component/s: wicket
• Labels: cache resource
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Terasaka Kinya
• Created: 28/Mar/12 08:39
• Updated: 02/Apr/12 12:28
• Resolved: 02/Apr/12 12:28

Description

The conditional statement 'if (resourceResponse.dataNeedsToBeWritten(attributes))' in PackageResource$newResourceResponse always turns true.

dataNeedsToBeWritten() method internally uses its own lastModified field, which is null (by default) and always returns true at that point resulting in getting a stream and processing it every time.

I think this ruins resource caching.

NOTE: The API document of dataNeedsToBeWritten() exclaims setLastModified() be called first.