Wicket
  1. Wicket
  2. WICKET-442

adding (and querying) feedback messages at construction time fails.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.5, 1.3.0-beta1
    • Fix Version/s: 1.3.0-beta1
    • Component/s: wicket
    • Labels:
      None

      Description

      See http://www.nabble.com/error%28...%29-No-page-found-for-component-tf3497125.html

      Currently, adding (and querying) feedback messages fails whenever it is done on components that are not yet added to a page (or were removed from them due to component replacement).

      There are two ways to fix this. The first fix is attached as a patch, and basically uses a thread local to temporarily store the messages and distribute them to the relevant page instances just in time or when rendering starts. The advantage of this method is that it is completely back wards compatible.

      The other way to fix this is to store all messages, whether component specific or not, in the session, and pull them from there. We need to be careful about how/ when to clean these error messages up though. We can use this issue to think about it a little bit more.

      1. WICKET-442.patch
        13 kB
        Eelco Hillenius
      2. WICKET-442-2.patch
        44 kB
        Eelco Hillenius
      3. WICKET-442-3.patch
        45 kB
        Eelco Hillenius

        Activity

        Hide
        Eelco Hillenius added a comment -

        Page centric solution

        Show
        Eelco Hillenius added a comment - Page centric solution
        Hide
        Eelco Hillenius added a comment -

        patch based on messages in the session

        Show
        Eelco Hillenius added a comment - patch based on messages in the session
        Hide
        Eelco Hillenius added a comment -

        alternative session based patch. This one clears all page specific components at the start of the events part of a request, rather than just for this specific page.

        Show
        Eelco Hillenius added a comment - alternative session based patch. This one clears all page specific components at the start of the events part of a request, rather than just for this specific page.
        Hide
        Eelco Hillenius added a comment -

        Implemented session based approach with aggressive cleanup, but with the option for people to override.

        Show
        Eelco Hillenius added a comment - Implemented session based approach with aggressive cleanup, but with the option for people to override.

          People

          • Assignee:
            Eelco Hillenius
            Reporter:
            Eelco Hillenius
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development