[WICKET-4398] Any empty url-parameter will make wicket 1.5 crash

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.3
• Fix Version/s: 1.5.5, 6.0.0-beta1
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Johannes Odland
• Created: 08/Feb/12 12:29
• Updated: 16/Feb/12 14:34
• Resolved: 09/Feb/12 10:00

Description

Adding an empty parameter to the query string will make wicket crash.

http://www.example.com/?oneParam&

How to reproduce in test:

PageParameters params = new PageParameters();
params.set("","");
params.getAllNamed();

Cause:
Wicket accepts empty parameters, but when encoding the url for a rendered page it will call params.getAllNamed().

params.getAllNamed() instantiates new NamedPairs, which calls Args.notEmpty() on the key during instantiation, causing the application to crash.

The NamedPair constructor should probably allow empty string as a key, and call Args.notNull() on the key in stead.