Wicket
  1. Wicket
  2. WICKET-4384

improve wicket's handling of empty / null page parameters

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.4, 6.0.0-beta1
    • Fix Version/s: 1.5.5, 6.0.0-beta1
    • Component/s: wicket
    • Labels:
      None

      Description

      • DefaultPageFactory#newPage() should be sure to not pass 'null' to a page constructor with page parameters

        Activity

        Peter Ertl created issue -
        Peter Ertl made changes -
        Field Original Value New Value
        Description ^ see summary after calling cleanPageParameters() an empty set of page parameters is returned as an empty PageParameters instance when in fact it should be 'null'
        Peter Ertl made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.5.5 [ 12319052 ]
        Fix Version/s 6.0.0 [ 12315431 ]
        Resolution Fixed [ 1 ]
        Peter Ertl made changes -
        Summary cleaning up PageParameters in AbstractBookmarkableMapper returns an empty instance if no parameters are left after sanitizing instead of 'null' which by wicket definition indicates that we have no page parameters improve wicket's handling of empty / null page parameters
        Description after calling cleanPageParameters() an empty set of page parameters is returned as an empty PageParameters instance when in fact it should be 'null' - after calling cleanPageParameters() an empty set of page parameters is returned as an empty PageParameters instance when in fact it should be 'null'
        - DefaultPageFactory#newPage() should be sure to not pass 'null' to a page constructor with page parameters
        Peter Ertl made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Peter Ertl made changes -
        Comment [ fixed in trunk ]
        Peter Ertl made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Peter Ertl made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Peter Ertl made changes -
        Description - after calling cleanPageParameters() an empty set of page parameters is returned as an empty PageParameters instance when in fact it should be 'null'
        - DefaultPageFactory#newPage() should be sure to not pass 'null' to a page constructor with page parameters
        - DefaultPageFactory#newPage() should be sure to not pass 'null' to a page constructor with page parameters
        Peter Ertl made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Peter Ertl
            Reporter:
            Peter Ertl
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development