Wicket
  1. Wicket
  2. WICKET-4363

Duplicate html ID for generated divs in modal.js

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.4
    • Fix Version/s: 1.5.5, 6.0.0-beta1
    • Component/s: wicket-extensions
    • Labels:
      None

      Description

      using wicket's ModalWindow creates invalid markup since it creates two divs with id="_wicket_window_11"

        Issue Links

          Activity

          Hide
          Rodolfo Hansen added a comment -

          simple fix

          Show
          Rodolfo Hansen added a comment - simple fix
          Hide
          Robert Niestroj added a comment -

          I think the bug is still there in Wicket 6.4.0

          This is the Panel i have in my modalWindow:

          <wicket:panel>
          <div wicket:id="formContainer">
          <div wicket:id="editInstallationFormPanel">

          </div>
          </div>
          <div class="ui-widget ui-corner-all" style="margin-top:10px;">
          <div wicket:id="filterForm" class="ui-widget-header ui-corner-top" style="padding: 5px;">

          </div>
          <table wicket:id="dataTable" class="ui-widget-content ui-corner-bottom">

          </table>
          </div>
          </wicket:panel>

          When i add the wicket:id="formContainer" to the target it gets duplicated with the same generated id.

          I have a link in the wicket:id="dataTable" for editing items from the datatable. This link uses replaceWith to replace the wicket:id="formContainer" with a new instance and then i add wicket:id="formContainer" to the AjaxRequestTarget. Then it doubles the formContainer div.

          Can you reopen this isse?

          Show
          Robert Niestroj added a comment - I think the bug is still there in Wicket 6.4.0 This is the Panel i have in my modalWindow: <wicket:panel> <div wicket:id="formContainer"> <div wicket:id="editInstallationFormPanel"> </div> </div> <div class="ui-widget ui-corner-all" style="margin-top:10px;"> <div wicket:id="filterForm" class="ui-widget-header ui-corner-top" style="padding: 5px;"> </div> <table wicket:id="dataTable" class="ui-widget-content ui-corner-bottom"> </table> </div> </wicket:panel> When i add the wicket:id="formContainer" to the target it gets duplicated with the same generated id. I have a link in the wicket:id="dataTable" for editing items from the datatable. This link uses replaceWith to replace the wicket:id="formContainer" with a new instance and then i add wicket:id="formContainer" to the AjaxRequestTarget. Then it doubles the formContainer div. Can you reopen this isse?
          Hide
          Martin Grigorov added a comment -

          Please attach a quickstart and we will reopen it.

          Show
          Martin Grigorov added a comment - Please attach a quickstart and we will reopen it.
          Hide
          Robert Niestroj added a comment -

          How do i create a quickstart?

          Show
          Robert Niestroj added a comment - How do i create a quickstart?
          Show
          Martin Grigorov added a comment - http://wicket.apache.org/start/quickstart.html
          Hide
          Martin Grigorov added a comment -

          The idea is that you create a mini application that exposes the problem so we can debug it and fix the problem.

          Show
          Martin Grigorov added a comment - The idea is that you create a mini application that exposes the problem so we can debug it and fix the problem.

            People

            • Assignee:
              Igor Vaynberg
              Reporter:
              Rodolfo Hansen
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development