[WICKET-4356] StringValueConversionException should not be thrown when requesting a conversion on StringValue with a default value

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.3
• Fix Version/s: 1.5.5, 6.0.0-beta1
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Sergei Sizov
• Created: 24/Jan/12 22:57
• Updated: 31/Jan/12 22:21
• Resolved: 31/Jan/12 11:28

Description

In my application I need to get current page parameter from PageParameters

so I use this code

PageParameters parameters = ...
int currentPage = parameters.get("page").toInt(1);

It works good when "page" parameter contains an Integer value or is null, but when it contains a non numeric value it throws an exception StringValueConversionException.

I would expect a little bit different behaviour. Why not to return DEFAULT value when StringValueConversionException is thrown? I think it is more secure and saves many lines of code, because you do not need to check that StringValue is really a string containing only numeric characters.