Wicket
  1. Wicket
  2. WICKET-432

getvariation() is called from webpage constructor through commoninit()

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.5
    • Fix Version/s: 1.2.6, 1.3.0-beta1
    • Component/s: wicket
    • Labels:
      None

      Description

      getvariation() is called from commoninit(). if user overrides getvariation() and makes it depend on variables initialized from his webpage subclass' constructor then this method is invoked before the constructor has finished - which of course leads to problems.

      getvariation should not be called from WebPage constructor

        Issue Links

          Activity

          Hide
          Igor Vaynberg added a comment -

          in fact now that we have great support for onload events in IHeaderContributor we can think about removing bodycontainer altogether as iheadercontributor is a much better solution

          Show
          Igor Vaynberg added a comment - in fact now that we have great support for onload events in IHeaderContributor we can think about removing bodycontainer altogether as iheadercontributor is a much better solution
          Hide
          Eelco Hillenius added a comment -

          +1 on that.

          Show
          Eelco Hillenius added a comment - +1 on that.
          Hide
          Matej Knopp added a comment -

          +1 as well

          Show
          Matej Knopp added a comment - +1 as well
          Hide
          Igor Vaynberg added a comment -

          so in 1.3 we can remove it, but in 1.2 we need to fix this problem

          Show
          Igor Vaynberg added a comment - so in 1.3 we can remove it, but in 1.2 we need to fix this problem
          Hide
          Igor Vaynberg added a comment -

          1.2.6 fix is done

          Show
          Igor Vaynberg added a comment - 1.2.6 fix is done

            People

            • Assignee:
              Igor Vaynberg
              Reporter:
              Igor Vaynberg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development