[WICKET-4309] StringValueConversionException for correct situation

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.3
• Fix Version/s: 1.5.4, 6.0.0-beta1
• Component/s: wicket
• Labels: StringValue StringValueConversionException
• Environment: Java 1.6, Jboss
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Ilia Naryzhny
• Created: 20/Dec/11 13:17
• Updated: 04/Jan/12 10:16
• Resolved: 04/Jan/12 10:16

Description

StringValue.toOptionalLong() produces org.apache.wicket.util.string.StringValueConversionException if empty string was passed.
Let me suggest, that this behavior should be changes for all toOptionalXXX methods except getOptionalString method.

The problem in inner code:

The problem in following code:

public final Long toOptionalLong() throws StringValueConversionException

{ return (text == null) ? null : toLongObject(); }

Should be something like this:

The problem in following code:

public final Long toOptionalLong() throws StringValueConversionException

{ return Strings.isEmpty() ? null : toLongObject(); }

But there is another problem: what to do if incorrect param was passed - for example "abc" for parameter of Long type?