[WICKET-4306] Content type overriding in PackageResource

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.3
• Fix Version/s: 1.5.4, 6.0.0-beta1
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Guillaume Smet
• Created: 19/Dec/11 11:15
• Updated: 20/Dec/11 10:16
• Resolved: 20/Dec/11 10:16

Description

Hello,

From my email on the dev@ list:
"
In a Resource extending PackageResource (a LessCSS implementation), we
set the content type on the ResourceStream to text/css.

The problem is that PackageResource overrides it in
newResourceResponse (starting from line 255 in 1.5.3):
final String contentType;
if (Application.exists())

{ contentType = Application.get().getMimeType(path); }

else

{ contentType = resourceStream.getContentType(); }

If not null, shouldn't we give the resourceStream's content type a
higher priority and use Application.get().getMimeType(path) only if it
is null?

IMHO we should probably have something like that:
final String contentType = resourceStream.getContentType();
if (contentType == null && Application.exists())
{
contentType = Application.get().getMimeType(path);
}
"

Thanks.

–
Guillaume