[WICKET-4300] JavaScript error "Uncaught TypeError: Cannot read property 'length' of undefined" in case of CheckGroupSelector and nested forms

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.3
• Fix Version/s: 1.5.4, 6.0.0-beta1
• Component/s: wicket
• Environment: JDK 1.6u27, Win64, Google Chrome 15.0.x
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Alexander Morozov
• Created: 15/Dec/11 17:53
• Updated: 16/Dec/11 15:09
• Resolved: 16/Dec/11 15:09

Description

Full stack trace is:

Uncaught TypeError: Cannot read property 'length' of undefined:
(anonymous function)CheckGroupSelector-ver-1323970753862.js:35
Wicket.CheckboxSelector.updateAllCheckboxesAbstractCheckSelector-ver-1323970753862.js:35
(anonymous function)

Caused by CheckGroupSelector.java:

@Override
protected CharSequence getFindCheckboxesFunction()
{
CheckGroup<?> group = getGroup();
if (group == null)

{ throw new WicketRuntimeException( "CheckGroupSelector component [" + getPath() + "] cannot find its parent CheckGroup. All CheckGroupSelector components must be a child of or below in the hierarchy of a CheckGroup component."); }

return "Wicket.CheckboxSelector.Group.findCheckboxesFunction('" +
group.getForm().getMarkupId() + "','" + group.getInputName() + "')";
}

The generated JS will address HTML form which is attached to check group, but this element may be not a root form (which is rendered as 'div' instead of 'form' element). JS code CheckGroupSelector:js:34 "parentForm[groupName]" can be evaluated to 'undefined'. I think, that "group.getForm().getMarkupId()" should be replaced by "group.getForm().getRootForm().getMarkupId()".