Wicket
  1. Wicket
  2. WICKET-4250

Checks in IRequestMapper.mapHandler should be on page instance, if available

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.3
    • Fix Version/s: 1.5.4, 6.0.0-beta1
    • Component/s: wicket
    • Labels:
      None

      Description

      AbstractBookmarkableMapper and MountedMapper only check if a the page class match that of the mount, even when a page instance is available. This makes it difficult to use the classes as superclass in a single-page application, where the same page can be mounted at different urls. The attached patch allows checks on the page instance to be implemented in subclasses.

        Activity

        Emond Papegaaij created issue -
        Emond Papegaaij made changes -
        Field Original Value New Value
        Attachment 0001-WICKET-4250.patch [ 12504491 ]
        Hide
        Martin Grigorov added a comment -

        I guess a test case wont be very simple to be created...
        At least the patch is simple.

        Show
        Martin Grigorov added a comment - I guess a test case wont be very simple to be created... At least the patch is simple.
        Martin Grigorov made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]
        Fix Version/s 1.5.4 [ 12319051 ]
        Fix Version/s 6.0.0 [ 12315431 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3d 3h 40m 1 Martin Grigorov 24/Nov/11 14:36

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Emond Papegaaij
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development