Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4250

Checks in IRequestMapper.mapHandler should be on page instance, if available

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.3
    • Fix Version/s: 1.5.4, 6.0.0-beta1
    • Component/s: wicket
    • Labels:
      None

      Description

      AbstractBookmarkableMapper and MountedMapper only check if a the page class match that of the mount, even when a page instance is available. This makes it difficult to use the classes as superclass in a single-page application, where the same page can be mounted at different urls. The attached patch allows checks on the page instance to be implemented in subclasses.

        Activity

        Hide
        mgrigorov Martin Grigorov added a comment -

        I guess a test case wont be very simple to be created...
        At least the patch is simple.

        Show
        mgrigorov Martin Grigorov added a comment - I guess a test case wont be very simple to be created... At least the patch is simple.

          People

          • Assignee:
            mgrigorov Martin Grigorov
            Reporter:
            papegaaij Emond Papegaaij
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development