Wicket
  1. Wicket
  2. WICKET-4247

HeaderResponseContainerFilteringHeaderResponse does not override enough methods

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.3
    • Fix Version/s: 1.5.4
    • Component/s: wicket
    • Labels:
      None

      Description

      Seen on Wicket 1.5.3 and I think it is still there in SVN.

      Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.

      Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.

      It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.

        Issue Links

          Activity

          Andreas Köhler created issue -
          Andreas Köhler made changes -
          Field Original Value New Value
          Attachment wicket-4247.tar.bz2 [ 12504437 ]
          Martin Grigorov made changes -
          Assignee Martin Grigorov [ mgrigorov ]
          Martin Grigorov made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 1.5.4 [ 12319051 ]
          Fix Version/s 6.0.0 [ 12315431 ]
          Resolution Fixed [ 1 ]
          Martin Grigorov made changes -
          Link This issue is duplicated by WICKET-4263 [ WICKET-4263 ]
          Martin Grigorov made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Emond Papegaaij made changes -
          Martin Grigorov made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Fix Version/s 6.0.0 [ 12315431 ]
          Resolution Fixed [ 1 ]
          Andreas Köhler made changes -

            People

            • Assignee:
              Martin Grigorov
              Reporter:
              Andreas Köhler
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development