[WICKET-4247] HeaderResponseContainerFilteringHeaderResponse does not override enough methods

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.3
• Fix Version/s: 1.5.4
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Andreas Köhler
• Created: 20/Nov/11 20:12
• Updated: 06/Jan/12 14:01
• Resolved: 21/Dec/11 12:17

Description

Seen on Wicket 1.5.3 and I think it is still there in SVN.

Major because users might be trapped thinking that their Javascript is at the bottom but it is not, having weird consequences.

Attached is a quickstart. It sets up a header response decorator with a header response sending javascript to the bottom which is optionally wrapped by a simple implementation of an aggregating header response. The wrapper though uses a full-arguments method to render javascript which is not fetched by the other response header. So the javascript ends up in the html head.

It should suffice to override the remaining four (js/css, resource ref/url) render methods to fix this.

Issue Links

• is duplicated by: WICKET-4263 Missing renderCSSReference- and renderJavascriptReference-Methods in HeaderResponseContainerFilteringHeaderResponse (have to be overwritten from DecoratingHeaderResponse)