Wicket
  1. Wicket
  2. WICKET-4245

AbstractResourceAggregatingHeaderResponse forgets some information about references

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.3
    • Fix Version/s: 1.5.4, 6.0.0-beta1
    • Component/s: wicket
    • Labels:
      None

      Description

      Seen in Wicket 1.5.3 and SVN r1199294. AbstractResourceAggregatingHeaderResponse.java

      public void renderJavaScriptReference(String url, String id, boolean defer)

      { topLevelReferences.add(new ResourceReferenceAndStringData(null, null, url, null, ResourceType.JS, defer, null, null)); }

      forgets the id.

      public void renderCSSReference(ResourceReference reference, PageParameters pageParameters,
      String media, String condition)

      { topLevelReferences.add(new ResourceReferenceAndStringData(reference, null, null, media, ResourceType.CSS, false, null, condition)); }

      forgets the page parameters.

      I think a quickstart should not be necessary.

        Activity

        Andreas Köhler created issue -
        Andreas Köhler made changes -
        Field Original Value New Value
        Description Seen in Wicket 1.5.3 and SVN r1199294. AbstractResourceAggregatingHeaderResponse.java

        {code}
            public void renderJavaScriptReference(String url, String id, boolean defer)
            {
                topLevelReferences.add(new ResourceReferenceAndStringData(null, null, url, null,
        ResourceType.JS, defer, null, null));
            }
        {code}
        forgets the id.

        {code}
            public void renderCSSReference(ResourceReference reference, PageParameters pageParameters,
                String media, String condition)
            {
              topLevelReferences.add(new ResourceReferenceAndStringData(reference, null, null, media,
                    ResourceType.CSS, false, null, condition));
            }
        {code}
        forgets the page parameters.

        I think a quickstart should not be necessary.
        Seen in Wicket 1.5.3 and SVN r1199294. AbstractResourceAggregatingHeaderResponse.java

            public void renderJavaScriptReference(String url, String id, boolean defer)
            {
                topLevelReferences.add(new ResourceReferenceAndStringData(null, null, url, null,
        ResourceType.JS, defer, null, null));
            }
        forgets the id.

            public void renderCSSReference(ResourceReference reference, PageParameters pageParameters,
                String media, String condition)
            {
              topLevelReferences.add(new ResourceReferenceAndStringData(reference, null, null, media,
                    ResourceType.CSS, false, null, condition));
            }
        forgets the page parameters.

        I think a quickstart should not be necessary.
        Hide
        Martin Grigorov added a comment -

        Thanks!

        Show
        Martin Grigorov added a comment - Thanks!
        Martin Grigorov made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]
        Fix Version/s 1.5.4 [ 12319051 ]
        Fix Version/s 6.0.0 [ 12315431 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        4d 18h 35m 1 Martin Grigorov 24/Nov/11 14:56

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Andreas Köhler
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development