Wicket
  1. Wicket
  2. WICKET-4244

Add EnhancedPageView to ease debugging with the InspectorPage

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 6.0.0-beta3
    • Fix Version/s: 6.0.0
    • Component/s: wicket-devutils
    • Labels:

      Description

      Add an enhanced PageView which displays all Components and Behaviors of a Page in a TableTree representation. Components and Behaviors can be shown based on their statefulness status. There are also filtering options to choose the information displayed (columns).

      1. v2_screen.jpg
        214 kB
        Bertrand Guay-Paquet
      2. stateful_page_inspector.patch
        22 kB
        Bertrand Guay-Paquet
      3. stateless_bar.png
        5 kB
        Bertrand Guay-Paquet
      4. stateful_bar.png
        5 kB
        Bertrand Guay-Paquet
      5. inspector.png
        48 kB
        Bertrand Guay-Paquet

        Activity

        Hide
        Bertrand Guay-Paquet added a comment -

        screenshots

        Show
        Bertrand Guay-Paquet added a comment - screenshots
        Hide
        Bertrand Guay-Paquet added a comment -

        proposed modifications

        Show
        Bertrand Guay-Paquet added a comment - proposed modifications
        Hide
        Bertrand Guay-Paquet added a comment -

        Is there no interest in this feature?

        Show
        Bertrand Guay-Paquet added a comment - Is there no interest in this feature?
        Hide
        Sven Meier added a comment -

        I'm interested in this feature. But couldn't we just include this information in the current page inspector?

        Show
        Sven Meier added a comment - I'm interested in this feature. But couldn't we just include this information in the current page inspector?
        Hide
        Martin Grigorov added a comment -

        The feature looks good. It just didn't appear in my Jira issues filter. I'll take a look at it soon.

        Show
        Martin Grigorov added a comment - The feature looks good. It just didn't appear in my Jira issues filter. I'll take a look at it soon.
        Hide
        Bertrand Guay-Paquet added a comment -

        Wow both comments at the same time!

        Yeah sure it could be changed to a Panel and included in the page inspector too. The InspectorDebugPanel would also need to be modified in order to show whether the current page is stateful or stateless.

        Show
        Bertrand Guay-Paquet added a comment - Wow both comments at the same time! Yeah sure it could be changed to a Panel and included in the page inspector too. The InspectorDebugPanel would also need to be modified in order to show whether the current page is stateful or stateless.
        Hide
        Sven Meier added a comment -

        >Wow both comments at the same time!

        Well, the InspectorPage shows all components anyway, adding another 'stateful/stateless' column shouldn't be hard. We could revamp its component listing with a tree-like display like the one you're using in your patch.

        Show
        Sven Meier added a comment - >Wow both comments at the same time! Well, the InspectorPage shows all components anyway, adding another 'stateful/stateless' column shouldn't be hard. We could revamp its component listing with a tree-like display like the one you're using in your patch.
        Hide
        Bertrand Guay-Paquet added a comment -

        Adding that other column is indeed easy. However, the big difference between this and my patch is that the latter only displays stateful components and their parent. This makes it a lot easier to spot the stateful components in pages with lots of stateless components.

        Show
        Bertrand Guay-Paquet added a comment - Adding that other column is indeed easy. However, the big difference between this and my patch is that the latter only displays stateful components and their parent. This makes it a lot easier to spot the stateful components in pages with lots of stateless components.
        Hide
        Bertrand Guay-Paquet added a comment -

        Screenshot of TableTree version

        Show
        Bertrand Guay-Paquet added a comment - Screenshot of TableTree version
        Hide
        Bertrand Guay-Paquet added a comment -

        While porting my code to Wicket 6, all the 1.5 Tree classes were marked deprecated so I created a new version with TableTree integrating Sven's ideas. I think the result is much better than the initial version.

        The only downside is that ExceptionErrorPage still uses the current PageView because it's in wicket-core and TableTree is in wicket-extension.

        I'll send a pull request

        Show
        Bertrand Guay-Paquet added a comment - While porting my code to Wicket 6, all the 1.5 Tree classes were marked deprecated so I created a new version with TableTree integrating Sven's ideas. I think the result is much better than the initial version. The only downside is that ExceptionErrorPage still uses the current PageView because it's in wicket-core and TableTree is in wicket-extension. I'll send a pull request
        Hide
        Martin Grigorov added a comment -

        Pull request applied!
        Thanks!

        Show
        Martin Grigorov added a comment - Pull request applied! Thanks!

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Bertrand Guay-Paquet
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development