Wicket
  1. Wicket
  2. WICKET-4207

Use the correct cast in WizardButtonBar

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.2
    • Fix Version/s: 1.5.3
    • Component/s: wicket-extensions
    • Labels:
      None

      Description

      WizardButtonBar.getDefaultButton() uses a cast to Button before returning the found component.
      However, the interface only expects a IFormSubmittingComponent being returned.
      This makes it hard to subclass this button bar to add our own logic using SubmitLinks instead of Buttons. Those casts should be changed to IFormSubmittingComponent.

        Activity

        Matthias Keller made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Martin Grigorov made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]
        Fix Version/s 1.5.3 [ 12318550 ]
        Fix Version/s 1.6.0 [ 12315431 ]
        Resolution Fixed [ 1 ]
        Martin Grigorov made changes -
        Field Original Value New Value
        Fix Version/s 1.6.0 [ 12315431 ]
        Matthias Keller created issue -

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Matthias Keller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development