[WICKET-4162] Add new StringResourceLoader to allow Wicket extensions to provide localization resource bundles

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.1
• Fix Version/s: 1.5.4, 6.0.0-beta1
• Component/s: wicket
• Labels: extension localization
• Assignee: Sven Meier
• Reporter: Bertrand Guay-Paquet
• Created: 22/Oct/11 16:02
• Updated: 25/Jul/12 17:12
• Resolved: 23/Nov/11 08:24

Description

Issue:
It is currently not possible to provide default localization resource bundles for components in wicket extension modules (e.g. wicket-extensions). See issues WICKET-3911 and WICKET-4154 where this was a problem.

Proposed changes:
1-Add a new IStringResourceLoader type (WicketExtensionStringResourceLoader?) which checks the root of the jar containing the component for properties in extension.properties.

2-Insert this new resource loader in the existing default resource loader chain:
ResourceSettings() constructor:
stringResourceLoaders.add(new ComponentStringResourceLoader());
stringResourceLoaders.add(new PackageStringResourceLoader());
stringResourceLoaders.add(new ClassStringResourceLoader(application.getClass()));
// New loader inserted here
stringResourceLoaders.add(new WicketExtensionStringResourceLoader());
stringResourceLoaders.add(new ValidatorStringResourceLoader());

3-Start adding extension.properties files in wicket-extension and friends.

Questions:
Is a similar effort already underway?
Are there any better ideas?
Should the new loader be inserted at the end of the chain instead?
Do you prefer other names for the loader or the properties file?

I am prepared to provide a patch sometime next week if this is agreed on.

Issue Links

• blocks: WICKET-3911 Hungarian localisation for upload component and examples
• blocks: WICKET-4239 add wicket-jar_es.properties for spanish localization
• blocks: WICKET-4154 Add localization resources for DataTable components
• is related to: WICKET-4211 package.properties should be prefixed with "wicket-" namespace