Wicket
  1. Wicket
  2. WICKET-4154

Add localization resources for DataTable components

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 1.5.3
    • Component/s: wicket-extensions
    • Labels:

      Description

      Add localization for DataTable components (no records and navigation toolbars)

      1. application_properties.patch
        8 kB
        Bertrand Guay-Paquet
      2. localize.patch
        3 kB
        Bertrand Guay-Paquet

        Issue Links

          Activity

          Hide
          Bertrand Guay-Paquet added a comment -

          French and English localization

          Show
          Bertrand Guay-Paquet added a comment - French and English localization
          Hide
          Sven Meier added a comment -

          If we add package specific properties in extensions, client applications will no longer be able to override these messages globally in their application.properties. I think the latter is something we should continue to support. WDYT?

          Show
          Sven Meier added a comment - If we add package specific properties in extensions, client applications will no longer be able to override these messages globally in their application.properties. I think the latter is something we should continue to support. WDYT?
          Hide
          Bertrand Guay-Paquet added a comment -

          You are right. I hadn't thought about that. I guess that's why I didn't see any package specific property files anywhere in Wicket!

          Show
          Bertrand Guay-Paquet added a comment - You are right. I hadn't thought about that. I guess that's why I didn't see any package specific property files anywhere in Wicket!
          Hide
          Bertrand Guay-Paquet added a comment -

          Another patch putting text in application.properties. Also modified application_fr.properties to xml format to ease its use with accented chars.

          Show
          Bertrand Guay-Paquet added a comment - Another patch putting text in application.properties. Also modified application_fr.properties to xml format to ease its use with accented chars.
          Hide
          Sven Meier added a comment -

          Hi Bertrand,

          regretfully the application properties won't do it either: We cannot define messages for components from wicket-extensions in wicket-core's application.properties .

          I've tried something similar a few months ago with uploadProgress, but had to revert it. Apparently there isn't a solution for this currently.

          Sven

          Show
          Sven Meier added a comment - Hi Bertrand, regretfully the application properties won't do it either: We cannot define messages for components from wicket-extensions in wicket-core's application.properties . I've tried something similar a few months ago with uploadProgress, but had to revert it. Apparently there isn't a solution for this currently. Sven
          Hide
          Bertrand Guay-Paquet added a comment -

          This is very strange! I am currently using the second patch I proposed and it works just fine.

          Is the problem that we don't want to "pollute" wicket-core property bundles with wicket-extensions stuff?

          Show
          Bertrand Guay-Paquet added a comment - This is very strange! I am currently using the second patch I proposed and it works just fine. Is the problem that we don't want to "pollute" wicket-core property bundles with wicket-extensions stuff?
          Hide
          Sven Meier added a comment -

          You're right, it works but as you've written it would "pollute" wicket-core with wicket-extensions messages.

          What we need is a solution for non-application libraries to be able to contribute global default messages after the client's application properties. Such a feature deserves its own issue.

          Show
          Sven Meier added a comment - You're right, it works but as you've written it would "pollute" wicket-core with wicket-extensions messages. What we need is a solution for non-application libraries to be able to contribute global default messages after the client's application properties. Such a feature deserves its own issue.
          Hide
          Bertrand Guay-Paquet added a comment -

          Good point. Please see WICKET-4162 for the new feature ticket.

          Show
          Bertrand Guay-Paquet added a comment - Good point. Please see WICKET-4162 for the new feature ticket.
          Hide
          Sven Meier added a comment -

          Added wicket-jar.properties

          Show
          Sven Meier added a comment - Added wicket-jar.properties

            People

            • Assignee:
              Sven Meier
              Reporter:
              Bertrand Guay-Paquet
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development