Wicket
  1. Wicket
  2. WICKET-4117

Improve markup parsing in order to generate a meaningful message when a not balanced quote is found.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.2
    • Component/s: wicket
    • Labels:
      None

      Description

      To solve WICKET-3773 XmlPullParser and FullyBufferedReader have become more "strict" in Wicket 1.5.1 . Now if markup contains not balanced quotes an exception is thrown. However exception message is 'No matching close bracket' and people may get confused.

      1. WICKET-4117.patch
        2 kB
        Andrea Del Bene

        Activity

        Hide
        Andrea Del Bene added a comment -

        See proposed patch. FullyBufferedReader has been improved and FullyBufferedReaderTest is now based on Junit 4 .

        Show
        Andrea Del Bene added a comment - See proposed patch. FullyBufferedReader has been improved and FullyBufferedReaderTest is now based on Junit 4 .
        Hide
        Martin Grigorov added a comment -

        The patch is applied with r1180823.
        Thanks Andrea!

        Show
        Martin Grigorov added a comment - The patch is applied with r1180823. Thanks Andrea!

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Andrea Del Bene
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development