[WICKET-4114] Mark getRequestCycleProvider in Application final

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.1
• Fix Version/s: 6.0.0-beta1
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Dilger
• Created: 08/Oct/11 11:07
• Updated: 18/Nov/11 10:14
• Resolved: 18/Nov/11 10:14

Description

A Developer should not be able to override getRequestCycleProvider, as this breaks some Functionality in BaseWicketTester, and to find out what goes wrong can be timeconsuming and can cause headaches.

BaseWicketTester does the following:
application.setRequestCycleProvider(new TestRequestCycleProvider(
application.getRequestCycleProvider()));

TestRequestCycleProvider provides the ability to force a certain RequestHandler (for example to Render a page used for BaseWicketTester#startPage,
this ignores the normal Process to resolve a RequestHandler.
If you override Application#getRequestCycleProvider, the Test will fail as Wicket will resolve the last RequestMapper in the Chain which is typically the HomePageMapper.

You Test will fail, and you might have real problems to find out whats going on, as I had last night.
Therefore I strongly recommend to mark #getRequestCycleProvider final. A developer has still the possibility to set a RequestCycleProvider with #setRequestCycleProvider, so we do not lose anything here.

Thanks

Martin Dilger