Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4114

Mark getRequestCycleProvider in Application final

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 6.0.0-beta1
    • Component/s: wicket
    • Labels:
      None

      Description

      A Developer should not be able to override getRequestCycleProvider, as this breaks some Functionality in BaseWicketTester, and to find out what goes wrong can be timeconsuming and can cause headaches.

      BaseWicketTester does the following:
      application.setRequestCycleProvider(new TestRequestCycleProvider(
      application.getRequestCycleProvider()));

      TestRequestCycleProvider provides the ability to force a certain RequestHandler (for example to Render a page used for BaseWicketTester#startPage,
      this ignores the normal Process to resolve a RequestHandler.
      If you override Application#getRequestCycleProvider, the Test will fail as Wicket will resolve the last RequestMapper in the Chain which is typically the HomePageMapper.

      You Test will fail, and you might have real problems to find out whats going on, as I had last night.
      Therefore I strongly recommend to mark #getRequestCycleProvider final. A developer has still the possibility to set a RequestCycleProvider with #setRequestCycleProvider, so we do not lose anything here.

      Thanks

      Martin Dilger

        Attachments

          Activity

            People

            • Assignee:
              mgrigorov Martin Grigorov
              Reporter:
              splitshade Martin Dilger
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: