[WICKET-4053] AbstractTree#updateTree(AjaxRequestTarget target) is invoked even when request is non-ajax

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.1
• Component/s: wicket
• Environment: Wicket 1.5.0
• Assignee: Peter Ertl
• Reporter: James McIntosh
• Created: 14/Sep/11 09:56
• Updated: 14/Sep/11 12:26
• Resolved: 14/Sep/11 12:26

Description

I came across an issue when trying to get Brix working in wicket 1.5.
It occurs when the Tree has: setLinkType(LinkType.REGULAR);

Caused by: java.lang.IllegalArgumentException: Argument 'target' may not be null.
at org.apache.wicket.util.lang.Args.notNull(Args.java:39)
at org.apache.wicket.markup.html.tree.AbstractTree.updateTree(AbstractTree.java:1138)
at org.apache.wicket.markup.html.tree.LinkIconPanel.onNodeLinkClicked(LinkIconPanel.java:82)
at org.apache.wicket.markup.html.tree.LinkIconPanel$1.onClick(LinkIconPanel.java:59)
at org.apache.wicket.markup.html.tree.BaseTree$5.onClick(BaseTree.java:386)
at org.apache.wicket.markup.html.link.Link.onLinkClicked(Link.java:187)

I only had a quick search across the wicket codebase to see if this method is called elsewhere

To fix LinkIconPanel line 82 should be
if (target != null) {
tree.updateTree(target);
}

BaseTree - line 294 also calls updateTree(target) with no null check.