Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Incomplete
    • Affects Version/s: 1.5-RC7
    • Fix Version/s: None
    • Component/s: wicket
    • Labels:
      None
    • Environment:
      Java(TM) SE Runtime Environment (build 1.6.0_25-b06)
      Java HotSpot(TM) Client VM (build 20.0-b11, mixed mode, sharing)
      Server: GlassFish 3.1.1

      Description

      I could verify that recovery after expiry works with parameters after the fix from issue 4014. This is more than what I could achieve with 1.4. After some more testing I found It breaks with the attached testcase where the GET parameter has the same name as the form field. I don't know whether this is out of scope.

      Please use the link "Expiry Recovery Form with Parameters Test". In the code TestPageFormParameters.html, TestPageFormParameters.java, I have commented out the version that works and replaced it with the bad one.

        Activity

        Hide
        bernard added a comment -

        Testcase

        Show
        bernard added a comment - Testcase
        Hide
        Martin Grigorov added a comment -

        Can you explain in more details what is the problem ?
        TestPageFormParameters is not mounted explicitly and the new functionality is not involved.

        Show
        Martin Grigorov added a comment - Can you explain in more details what is the problem ? TestPageFormParameters is not mounted explicitly and the new functionality is not involved.
        Hide
        bernard added a comment -

        Sorry, I should have mounted the page:

        mountPage("testFormParameters", TestPageFormParameters.class);

        My idea (to break it) was to use the same URL (GET) parameter name as one the form field names. Then there is a clash. I guess this could potentially be avoided with a distinction via org.apache.wicket.request.Request#getPostParameters, #getQueryParameters but I might be wrong.

        In 1.5-RC7, this works at the 2nd time when the parameters are no longer in the browsers URL bar. I really don't know what is going on.

        Show
        bernard added a comment - Sorry, I should have mounted the page: mountPage("testFormParameters", TestPageFormParameters.class); My idea (to break it) was to use the same URL (GET) parameter name as one the form field names. Then there is a clash. I guess this could potentially be avoided with a distinction via org.apache.wicket.request.Request#getPostParameters, #getQueryParameters but I might be wrong. In 1.5-RC7, this works at the 2nd time when the parameters are no longer in the browsers URL bar. I really don't know what is going on.
        Hide
        Martin Grigorov added a comment -

        Closing as "Incomplete" because it is still not clear what exactly is the problem.

        Show
        Martin Grigorov added a comment - Closing as "Incomplete" because it is still not clear what exactly is the problem.

          People

          • Assignee:
            Unassigned
            Reporter:
            bernard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development