Wicket
  1. Wicket
  2. WICKET-3988

Make AbstractMapper.getPlaceholder and similar methods as public methods

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5-RC6
    • Fix Version/s: 1.5-RC7
    • Component/s: wicket
    • Labels:
      None

      Description

      Playing with mappers and Scala I found that because of Scala's limitation, there's no way to call protected static methods even from subclasses.

      Thinking about Wicket-Scala interoperability, I think that these methods could be changed to public or to non-static methods.

      There's no gain nor design reason to leave these methods as protected static, IMO.

      1. patch-3988.diff
        1 kB
        Bruno Borges

        Activity

        Hide
        Martin Grigorov added a comment -

        I made them non-static.

        Show
        Martin Grigorov added a comment - I made them non-static.
        Hide
        Andrea Del Bene added a comment -

        +1 to make them non-static. IMHO a protected/private static method doesn't make much sense (maybe they perform better?).

        Show
        Andrea Del Bene added a comment - +1 to make them non-static. IMHO a protected/private static method doesn't make much sense (maybe they perform better?).
        Hide
        Bruno Borges added a comment -

        To keep backwards compatibility, just changing them to public is enough

        Show
        Bruno Borges added a comment - To keep backwards compatibility, just changing them to public is enough

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Bruno Borges
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development