Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3978

Delegate the Page#isBookmarkable() to the IPageFactory implementation

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.5-RC5.1
    • 1.5-RC6
    • wicket
    • None

    Description

      Currently org.apache.wicket.Page.isBookmarkable() checks whether the page is bookmarkable by checking whether it have either default constructor or a constructor with one parameter of type PageParameters.class.
      I think this logic should be delegated to the configured org.apache.wicket.IPageFactory because org.apache.wicket.session.DefaultPageFactory works with these two constructors but custom IPageFactory can work with more/less/other constructors.

      Attachments

        1. WICKET-3978.patch
          4 kB
          Martin Tzvetanov Grigorov
        2. WICKET-3978.patch
          4 kB
          Martin Tzvetanov Grigorov

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mgrigorov Martin Tzvetanov Grigorov
            mgrigorov Martin Tzvetanov Grigorov
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment