Wicket
  1. Wicket
  2. WICKET-3851

Remove usage of System.gc() in Wicket code

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5-RC5.1
    • Fix Version/s: 1.5-RC6
    • Component/s: wicket
    • Labels:
      None

      Description

      org.apache.wicket.util.file.Files.remove(File) calls System.gc() when a file cannot be removed for any reason.
      This call popped up in our performance tests.

      I suggest to try to delete the file at most N times and if it still not deleted then log a warning and schedule it for deletion when the JVM exists (java.io.File.deleteOnExit())

        Activity

        Hide
        Martin Grigorov added a comment -

        Files.remove() was the only place where System.gc() has been used.

        Show
        Martin Grigorov added a comment - Files.remove() was the only place where System.gc() has been used.

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Martin Grigorov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development