Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5-RC5.1
    • Fix Version/s: 1.5-RC6
    • Component/s: None
    • Labels:
      None
    • Environment:
      all

      Description

      Method objectRemoved looks for WebSssion but
      methods objectCreated and objectUpdated look for
      Session.

      In the objectCreated, objectUpdated and objectRemoved
      methods for Sessions, why not log the Session's id
      just as he page's id is logged? It will make it easier
      of line-up Session events with a particular session.

      LinkedList override method add only removes one
      entry, which assumes that the RequestsWindowSize
      (Application.get.getRequestLoggerSettings.getRequestsWindowSize)
      can not be changed (shrunk) at runtime (as the
      application is running).

      In method requestTime, when will the final else-statement
      be executed:

      SessionData sd = liveSessions.get(sessionId);
      if (sd == null)

      { // passivated session or logger only started after it. sessionCreated(sessionId); sd = liveSessions.get(sessionId); }

      // NOTE: at this point sd != null
      if (sd != null)

      { sd.setSessionInfo(sessionInfo); sd.setSessionSize(sizeInBytes); sd.addTimeTaken(timeTaken); log(rd, sd); }

      else

      { log(rd, null); }

      As an aside, you might have the method, sessionCreated return
      the SessionData it just created so in the above code one would have:
      if (sd == null)

      { // passivated session or logger only started after it. sd = sessionCreated(sessionId); }

        Activity

        Richard Emberson created issue -
        Hide
        Martin Grigorov added a comment -

        Martijn, you'll touch this code today anyway

        Show
        Martin Grigorov added a comment - Martijn, you'll touch this code today anyway
        Martin Grigorov made changes -
        Field Original Value New Value
        Assignee Martijn Dashorst [ dashorst ]
        Martijn Dashorst committed 1141520 (1 file)
        Reviews: none

        Closes WICKET-3839 (other items were solved in previous commit, related to WICKET-3832

        Hide
        Martijn Dashorst added a comment -

        Solved as part of WICKET-3832

        Show
        Martijn Dashorst added a comment - Solved as part of WICKET-3832
        Martijn Dashorst made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.5-RC6 [ 12316657 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Martijn Dashorst
            Reporter:
            Richard Emberson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development