[WICKET-3839] RequestLogger issues

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.5-RC5.1
• Fix Version/s: 1.5-RC6
• Environment: all
• Assignee: Martijn Dashorst
• Reporter: Richard Emberson
• Created: 27/Jun/11 23:18
• Updated: 30/Jun/11 12:59
• Resolved: 30/Jun/11 12:59

Description

Method objectRemoved looks for WebSssion but
methods objectCreated and objectUpdated look for
Session.

In the objectCreated, objectUpdated and objectRemoved
methods for Sessions, why not log the Session's id
just as he page's id is logged? It will make it easier
of line-up Session events with a particular session.

LinkedList override method add only removes one
entry, which assumes that the RequestsWindowSize
(Application.get.getRequestLoggerSettings.getRequestsWindowSize)
can not be changed (shrunk) at runtime (as the
application is running).

In method requestTime, when will the final else-statement
be executed:

SessionData sd = liveSessions.get(sessionId);
if (sd == null)

{ // passivated session or logger only started after it. sessionCreated(sessionId); sd = liveSessions.get(sessionId); }

// NOTE: at this point sd != null
if (sd != null)

{ sd.setSessionInfo(sessionInfo); sd.setSessionSize(sizeInBytes); sd.addTimeTaken(timeTaken); log(rd, sd); }

else

{ log(rd, null); }

As an aside, you might have the method, sessionCreated return
the SessionData it just created so in the above code one would have:
if (sd == null)

{ // passivated session or logger only started after it. sd = sessionCreated(sessionId); }