Wicket
  1. Wicket
  2. WICKET-3794

Simplify BrowserInfoPage by using InterceptData

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5-RC4
    • Fix Version/s: 1.5-RC5
    • Component/s: wicket
    • Labels:
      None

      Description

      http://localhost:8080/hellobrowser/ application is broken in current trunk.
      The problem is that it calculates the "continueTo" url too soon (before render time) and the generated url is wrong relative to the URL of the page that is going to be rendered.

      The whole concept can be greatly simplified by using org.apache.wicket.RestartResponseAtInterceptPageException.

        Activity

        Hide
        Adam Gray added a comment -

        How does this handle already being at an intercept page? For instance, a login page that needs to check browser compatibility. Will the second continueToOriginalDestination() work correctly?

        Example:

        http://www.example.com/reports
        intercept
        http://www.example.com/login
        intercept
        http://www.example.com/browserInfo

        After the browser info is collected, will the original destination for /reports still be available from the login page? I didn't think you could nest intercept pages like this.

        Show
        Adam Gray added a comment - How does this handle already being at an intercept page? For instance, a login page that needs to check browser compatibility. Will the second continueToOriginalDestination() work correctly? Example: http://www.example.com/reports intercept http://www.example.com/login intercept http://www.example.com/browserInfo After the browser info is collected, will the original destination for /reports still be available from the login page? I didn't think you could nest intercept pages like this.
        Hide
        Martin Grigorov added a comment -

        Please create a demo app and attach it here if it doesn't work.

        Show
        Martin Grigorov added a comment - Please create a demo app and attach it here if it doesn't work.

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Martin Grigorov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development