Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3783

Rework AttributeModifier, SimpleAtttributeModifier, AttributeAppender to simplify working with them

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5-RC4
    • Fix Version/s: 1.5-RC5
    • Component/s: wicket
    • Labels:
      None

      Description

      Transcript of a short IRC chat:

      17:54 dashorst
      ivaynberg: martin-g: I made SimpleAttributeModifier not to keep less
      state but to lessen the stuff needed to instantiate a
      AttributeModifier
      if you're concerned about the state of AM, then override oncomponenttag

      17:54 ivaynberg
      once we have the factories why not deprecate simple?

      17:54 dashorst
      I want to deprecate simple

      17:54 ivaynberg
      sometimes that cant be done
      if it could we wouldnt need AM
      anyways
      i think we should remove AM#replaceIfNotPresent
      i cant come up with a good usecase when it should be false

      17:56 dashorst
      neither can I

      17:56 ivaynberg
      nuke it and that will partially remove the need for simple* as well

      17:56 dashorst
      AM is usable for reuse, overriding oncomponenttag not
      though the component in question could be reusable

      17:57 ivaynberg
      make replaceModel Object
      so we can take simple values
      and instanceof it to see if its a model
      that will also save state
      the pattern thing can also go

      17:59 dashorst
      the pattern thing got me confused... no docs on what gets actually replaced
      the matched pattern? everything?

      17:59 ivaynberg
      yeah. nuke it.
      it seems like a very edgy edgecase
      also the enabled boolean
      it seems rather strange
      you would have to keep a reference to AM to toggle it
      i think people are much more likely to override isenabled()

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              dashorst Martijn Dashorst
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: