Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3781

Differentiate Google Chrome from Safari in wicket-xyz.js

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5-RC4
    • Fix Version/s: 1.5-RC5
    • Component/s: wicket
    • Labels:
      None

      Description

      Currently Google Chrome is treated as Safari in wicket-ajax.js and wicket-event.js.
      This causes Wicket.replaceOuterHtmlSafari() to be used while Chrome supports Range and ContextualFragment like Gecko browsers.
      The special code in replaceOuterHtmlSafari() is for older versions of Safari but it is hard to test, so improvements in this area for Safari 5 will be done when Wicket Ajax starts use some JS library.

      This change is a bit risky because until now Chrome was treated as Safari and we all tested this behavior but I tested all Ajax examples in wicket-examples and my application and everything seems to be OK.

        Attachments

        1. wicket-3781.patch
          1 kB
          Martin Tzvetanov Grigorov

          Activity

            People

            • Assignee:
              mgrigorov Martin Tzvetanov Grigorov
              Reporter:
              mgrigorov Martin Tzvetanov Grigorov
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: