[WICKET-3741] Don't throw MarkupNotFoundException when the markup is acceptable to not be available yet

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5-RC4
• Fix Version/s: 1.5-RC5
• Component/s: wicket
• Assignee: Juegen Donnerstag
• Reporter: Martin Tzvetanov Grigorov
• Created: 25/May/11 09:54
• Updated: 05/Jun/11 12:29
• Resolved: 05/Jun/11 12:29

Description

Some areas in Wicket code do expensive creation of WicketRuntimeException and then just ignores it.

The most common case is :

at java.lang.Throwable.fillInStackTrace(Native Method)
at java.lang.Throwable.<init>(Throwable.java:218)
at java.lang.Exception.<init>(Exception.java:59)
at java.lang.RuntimeException.<init>(RuntimeException.java:61)
at org.apache.wicket.WicketRuntimeException.<init>(WicketRuntimeException.java:49)
at org.apache.wicket.MarkupContainer.getMarkupType(MarkupContainer.java:476)
at org.apache.wicket.markup.DefaultMarkupCacheKeyProvider.getCacheKey(DefaultMarkupCacheKeyProvider.java:85)
at org.apache.wicket.markup.MarkupCache.getMarkup(MarkupCache.java:274)
at org.apache.wicket.markup.MarkupFactory.getMarkup(MarkupFactory.java:218)
at org.apache.wicket.markup.MarkupFactory.getMarkup(MarkupFactory.java:192)
at org.apache.wicket.MarkupContainer.getAssociatedMarkup(MarkupContainer.java:410)
at org.apache.wicket.markup.html.panel.PanelMarkupSourcingStrategy.getMarkup(PanelMarkupSourcingStrategy.java:70)
at org.apache.wicket.MarkupContainer.getMarkup(MarkupContainer.java:456)
at org.apache.wicket.Component.getMarkup(Component.java:734)
at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:173)
...

and is ignored in MarkupContainer#add().
Such an exception is created for every component which is added in the constructor of another component (in contrast to onInitialize() where the markup will be available).