[WICKET-3710] org/ apache/wicket/markup/html/tree/AbstractTree.java treeNodesRemoved loops forever

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5-RC4
• Fix Version/s: 1.4.18, 1.5-RC5
• Component/s: wicket
• Environment: all
• Assignee: Igor Vaynberg
• Reporter: Richard Emberson
• Created: 13/May/11 16:24
• Updated: 13/May/11 17:10
• Resolved: 13/May/11 17:10

Description

In the new code just added to AbstractTree, what happens if the cursor is NOT a TreeNode:

for (Object selectedNode : selection)
{
Object cursor = selectedNode;
while (cursor != null)
{
if (removed.contains(cursor))

{ getTreeState().selectNode(selectedNode, false); }

if (cursor instanceof TreeNode)

{ cursor = ((TreeNode)cursor).getParent(); }

}
}

I will loop forever. Or, if cursor is always a TreeNode (or null), why do the instanceof test.