[WICKET-3607] make ModalWindow CSS contibution more configurable

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.17, 1.5-RC3
• Fix Version/s: 1.4.18, 1.5-RC4
• Component/s: wicket-extensions
• Labels: wicket
• Environment: any
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Ernesto Reinaldo Barreiro
• Created: 11/Apr/11 11:51
• Updated: 20/Dec/11 05:58
• Resolved: 18/Apr/11 13:23

Description

Right now if you want to modify the CSS of ModalWindow you still get added to page the original CSS as it is included in

/**

• Initialize
  */
  private void init() { setVersioned(false); cookieName = null; add(empty = new WebMarkupContainer(getContentId())); add(newCloseButtonBehavior()); add(new WindowClosedBehavior()); add(JavascriptPackageResource.getHeaderContribution(JAVASCRIPT)); add(CSSPackageResource.getHeaderContribution(CSS)); }

I propose to do this as

/**

• Initialize
  */
  private void init() { setVersioned(false); cookieName = null; add(empty = new WebMarkupContainer(getContentId())); add(newCloseButtonBehavior()); add(new WindowClosedBehavior()); add(JavascriptPackageResource.getHeaderContribution(JAVASCRIPT)); ResourceReference CSS = newCssResource(); if (CSS != null) add(CSSPackageResource.getHeaderContribution(CSS)); }

/**

• Allows to override CSS contribution. Returning null means the CSS will be contributed via
• other sources, e.g. a global CSS resource.
• @return The CSS resource reference or null if CSS is contributed via other means.
  */
  protected ResourceReference newCssResource() { return CSS; }

This will allow to easily override the CSS file.... or avoid including one (returning null)... in case the CSS is part of a "global" page CSS... Existing applications will not be affected