Wicket
  1. Wicket
  2. WICKET-3597

Wicket 1.5 RC-3 Bug with conditional comments

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5-RC3
    • Fix Version/s: 1.5-RC4
    • Component/s: wicket
    • Labels:
    • Environment:
      Windows 7 64b - Chrome 11, Firefox 3.6

      Description

      IE Conditional Comments with script block causes malformed HTML on Chrome and Firefox.

      1. ASF.LICENSE.NOT.GRANTED--Chrome 11 Bug.jpg
        101 kB
        Gabriel Moreira
      2. ASF.LICENSE.NOT.GRANTED--Firefox bug.jpg
        82 kB
        Gabriel Moreira
      3. ASF.LICENSE.NOT.GRANTED--screenshot-1.jpg
        104 kB
        Gabriel Moreira
      4. myproject.rar
        19 kB
        Gabriel Moreira

        Issue Links

          Activity

          Hide
          Martin Grigorov added a comment -

          Use org.apache.wicket.markup.html.IHeaderResponse.renderString(CharSequence) for such needs.

          Show
          Martin Grigorov added a comment - Use org.apache.wicket.markup.html.IHeaderResponse.renderString(CharSequence) for such needs.
          Hide
          Branden Visser added a comment -

          I'm a little curious about the impact of the change in this commit. If you have a script tag that is not of type "text/javascript", then injecting a /* into the element may have undesired consequences on the template. Is it not valid to have a script tag with type="text/html", and not have /* injected to the output?

          Show
          Branden Visser added a comment - I'm a little curious about the impact of the change in this commit. If you have a script tag that is not of type "text/javascript", then injecting a /* into the element may have undesired consequences on the template. Is it not valid to have a script tag with type="text/html", and not have /* injected to the output?
          Hide
          Martin Grigorov added a comment -

          Fixed with r1089558.

          Show
          Martin Grigorov added a comment - Fixed with r1089558.

            People

            • Assignee:
              Martin Grigorov
              Reporter:
              Gabriel Moreira
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development