Wicket
  1. Wicket
  2. WICKET-3444

ChangeHandler fires in IE on POS1 and END

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.15
    • Fix Version/s: 1.4.16, 1.5-RC2
    • Component/s: wicket
    • Labels:
    • Environment:
      IE 8

      Description

      In wicket-ajax.js the Wicket.ChangeHandler fires in IE an event on Textfields even if the KEY_POS1 and the KEY_END is pressed.
      Please add
      obj.onkeyup = function(event) {
      switch (wicketKeyCode(Wicket.fixEvent(event)))

      { case KEY_ENTER: case KEY_UP: case KEY_DOWN: case KEY_ESC: case KEY_TAB: case KEY_RIGHT: case KEY_LEFT: case KEY_SHIFT: case KEY_ALT: case KEY_CTRL: return Wicket.stopEvent(event); break; default: if (typeof objonchange == "function")objonchange(); }

      return null;
      }

      case KEY_POS1 and KEY_END to the first case so that these two keys don't fall in the default case.

        Activity

        Hide
        Martin Grigorov added a comment - - edited

        What is POS1 ?
        Do you mean HOME ?

        Show
        Martin Grigorov added a comment - - edited What is POS1 ? Do you mean HOME ?
        Hide
        Martin Grigorov added a comment -

        Improved with r1070610 (1.4.x) and r1070612 (trunk).

        Show
        Martin Grigorov added a comment - Improved with r1070610 (1.4.x) and r1070612 (trunk).
        Hide
        Hudson added a comment -

        Integrated in Apache Wicket 1.4.x #439 (See https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/439/)
        WICKET-3444 ChangeHandler fires in IE on POS1 and END

        Do not fire event when HOME/END keys are pressed.

        Show
        Hudson added a comment - Integrated in Apache Wicket 1.4.x #439 (See https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/439/ ) WICKET-3444 ChangeHandler fires in IE on POS1 and END Do not fire event when HOME/END keys are pressed.
        Hide
        count negative added a comment -

        Yes I mean the Home Key. On a German Keyboard it's the POS1 key.

        Thanks!

        Show
        count negative added a comment - Yes I mean the Home Key. On a German Keyboard it's the POS1 key. Thanks!

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            count negative
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development