Wicket
  1. Wicket
  2. WICKET-3429

org/apache/wicket/util/resource/UrlResourceStream.java uses indexOf

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5-RC1
    • Fix Version/s: 1.5-RC2
    • Component/s: wicket
    • Labels:
      None
    • Environment:
      all

      Description

      I note that in many places String "indexOf" ==/!= -1 was replaced with "contains" in the RC1
      release. If this is a suggested usage pattern, then change:
      streamData.contentType.indexOf("unknown") != -1)
      to:
      streamData.contentType.contains("unknown"))

        Activity

        Richard Emberson created issue -
        Hide
        Martin Grigorov added a comment -

        With r1069863 it is changed to use #contains().
        There is no pattern in this. Both methods do the same.

        Show
        Martin Grigorov added a comment - With r1069863 it is changed to use #contains(). There is no pattern in this. Both methods do the same.
        Martin Grigorov made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]
        Fix Version/s 1.5-RC2 [ 12316059 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Richard Emberson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development